[improve][ml] Optimization method getNumberOfEntries #23576
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodece
approved these changes
Nov 7, 2024
|
/pulsarbot rerun-failure-checks |
dao-jun
approved these changes
Nov 12, 2024
|
/pulsarbot rerun-failure-checks |
nodece
approved these changes
Dec 13, 2024
|
/pulsarbot rerun-failure-checks |
|
close & reopen to trigger CI |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #23576 +/- ##
============================================
+ Coverage 73.57% 75.49% +1.91%
- Complexity 32624 37348 +4724
============================================
Files 1877 1946 +69
Lines 139502 155026 +15524
Branches 15299 17834 +2535
============================================
+ Hits 102638 117030 +14392
- Misses 28908 29383 +475
- Partials 7956 8613 +657
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
@hanmz Please rebase master branch. |
hanmz
force-pushed
the
improve/getNumberOfEntries
branch
from
9093593 to
decc815
Compare
|
reopen to trigger CI |
Done, please help me review again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, when
readPosition==lastPosition‘next, getNumberOfEntries will be entered. However, this is meaningless and may affect performance.For example, readPosition=3:0, lastPosition=3:-1, will enter the getNumberOfEntries method
Modifications
When
readPositionis greater thanlastPosition, return 0 directly.Documentation
docdoc-requireddoc-not-neededdoc-complete