[improve][client] Add newMessage with schema and transactions #23942
+61
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
doc
BewareMyPower
requested changes
Feb 7, 2025
Comment on lines
+147
to
+148
| <V> TypedMessageBuilder<V> newMessage(Schema<V> schema, | ||
| Transaction txn); |
There was a problem hiding this comment.
This change adds a new public API, which requires a PIP. https://github.com/apache/pulsar/tree/master/pip#when-is-a-pip-required
BTW, for this implementation PR, you should add a test to ensure it works.
There was a problem hiding this comment.
Is there a test suite for the producer? I was unable to find one to add to.
There was a problem hiding this comment.
No. Instead, I think you should add a test to TransactionTest to show which case this new API should be used. e.g.
// producer is a Producer<String> while value is a String rather than byte[]
producer.newMessage(schema, txn).value(value).send();
|
For PIP process, pls referring to https://github.com/apache/pulsar/tree/master/pip#pulsar-improvement-proposal-pip |
|
PIP PR filed here: #23950, will follow those guidelines by emailing out to the thread soon, etc. |
Pulsar Client allows callers to create messages with a schema or a transaction, but not both. This commit adds a new method in the producer that allows callers to create a message with both a schema and transaction.
omarkj
force-pushed
the
producer-new-message-schema-txn
branch
from
d77ad02 to
59dd60a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulsar Client allows callers to create messages with a schema or a transaction, but not both.
This commit adds a new method in the producer that allows callers to create a message with both a schema and transaction.
Documentation
docdoc-requireddoc-not-neededdoc-complete