Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][ci] Skip "OWASP dependency check" when data wasn't found in cache #23970

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

lhotari
Copy link
Member

@lhotari lhotari commented Feb 12, 2025

Motivation

Pulsar CI runs an "OWASP dependency check" build as part of the CI workflow when a dependency is updated.
This can take very long for Pull Request builds when the dependency check data isn't found in the cache.

Warning:  An NVD API Key was not provided - it is highly recommended to use an NVD API key as the update can take a VERY long time without an API Key
[INFO] NVD API has 280,989 records in this update
[INFO] Downloaded 10,000/280,989 (4%)
[INFO] Downloaded 20,000/280,989 (7%)
[INFO] Downloaded 30,000/280,989 (11%)
[INFO] Downloaded 40,000/280,989 (14%)
[INFO] Downloaded 50,000/280,989 (18%)
[INFO] Downloaded 60,000/280,989 (21%)
[INFO] Downloaded 70,000/280,989 (25%)
[INFO] Downloaded 80,000/280,989 (28%)
[INFO] Downloaded 90,000/280,989 (32%)
[INFO] Downloaded 100,000/280,989 (36%)
[INFO] Downloaded 110,000/280,989 (39%)
[INFO] Downloaded 120,000/280,989 (43%)
[INFO] Downloaded 130,000/280,989 (46%)
[INFO] Downloaded 140,000/281,043 (50%)
[INFO] Downloaded 150,000/281,043 (53%)
[INFO] Downloaded 160,000/281,043 (57%)
[INFO] Downloaded 170,000/281,043 (60%)
...

Modifications

Skip running "OWASP dependency check" when the dependency check data isn't found in the cache.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@lhotari lhotari added this to the 4.1.0 milestone Feb 12, 2025
@lhotari lhotari self-assigned this Feb 12, 2025
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Feb 12, 2025
@lhotari lhotari closed this Feb 12, 2025
@lhotari lhotari reopened this Feb 12, 2025
@lhotari lhotari merged commit 0a95976 into apache:master Feb 12, 2025
76 of 83 checks passed
lhotari added a commit that referenced this pull request Feb 12, 2025
lhotari added a commit that referenced this pull request Feb 12, 2025
lhotari added a commit that referenced this pull request Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants