Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix][connector-http] fix when post have param #8434

Open
wants to merge 14 commits into
base: dev
Choose a base branch
from

Conversation

CosmosNi
Copy link
Contributor

@CosmosNi CosmosNi commented Jan 3, 2025

fix when post have param.
#8431

Purpose of this pull request

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

@github-actions github-actions bot added the e2e label Jan 3, 2025
@CosmosNi
Copy link
Contributor Author

CosmosNi commented Jan 6, 2025

@hailin0 @Hisoka-X PTAL

@CosmosNi
Copy link
Contributor Author

CosmosNi commented Jan 8, 2025

@Hisoka-X PTAL

@Hisoka-X
Copy link
Member

Hisoka-X commented Jan 8, 2025

After discussing with @CosmosNi offline, we believe that the current behavior of param is incorrect, and we need to:

  1. Correct the existing meaning of params, which represents the parameters after the URL.
  2. The body supports two types: JSON or form, decided by the type configured by the user (i.e., the user needs to configure the corresponding header, with JSON as the default).
  3. The values of pagination parameters can be injected into either params or the body.
  4. Add configuration to support rolling back to the old behavior.

cc @hailin0

@github-actions github-actions bot removed the http label Jan 10, 2025
@github-actions github-actions bot added the api label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants