Skip to content

Commit

Permalink
Refactor StorageUnitManager (#34552)
Browse files Browse the repository at this point in the history
  • Loading branch information
terrymanu authored Feb 1, 2025
1 parent fba994e commit 2993864
Showing 1 changed file with 6 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,8 @@ public synchronized void register(final String databaseName, final Map<String, D
ShardingSphereDatabase database = metaDataContexts.getMetaData().getDatabase(databaseName);
try {
closeStaleRules(database);
buildNewMetaDataContext(databaseName, resourceSwitchManager.switchByRegisterStorageUnit(database.getResourceMetaData(), propsMap));
SwitchingResource switchingResource = resourceSwitchManager.switchByRegisterStorageUnit(database.getResourceMetaData(), propsMap);
buildNewMetaDataContext(databaseName, switchingResource);
} catch (final SQLException ex) {
log.error("Alter database: {} register storage unit failed.", databaseName, ex);
}
Expand All @@ -76,7 +77,8 @@ public synchronized void alter(final String databaseName, final Map<String, Data
ShardingSphereDatabase database = metaDataContexts.getMetaData().getDatabase(databaseName);
try {
closeStaleRules(database);
buildNewMetaDataContext(databaseName, resourceSwitchManager.switchByAlterStorageUnit(database.getResourceMetaData(), propsMap));
SwitchingResource switchingResource = resourceSwitchManager.switchByAlterStorageUnit(database.getResourceMetaData(), propsMap);
buildNewMetaDataContext(databaseName, switchingResource);
} catch (final SQLException ex) {
log.error("Alter database: {} alter storage unit failed.", databaseName, ex);
}
Expand All @@ -92,7 +94,8 @@ public synchronized void unregister(final String databaseName, final String stor
ShardingSphereDatabase database = metaDataContexts.getMetaData().getDatabase(databaseName);
try {
closeStaleRules(database);
buildNewMetaDataContext(databaseName, resourceSwitchManager.switchByUnregisterStorageUnit(database.getResourceMetaData(), Collections.singleton(storageUnitName)));
SwitchingResource switchingResource = resourceSwitchManager.switchByUnregisterStorageUnit(database.getResourceMetaData(), Collections.singleton(storageUnitName));
buildNewMetaDataContext(databaseName, switchingResource);
} catch (final SQLException ex) {
log.error("Alter database: {} register storage unit failed.", databaseName, ex);
}
Expand Down

0 comments on commit 2993864

Please sign in to comment.