Optimize DatabaseExportMetaDataGenerator, null value properties are n…

…ot exported
apache · Dec 26, 2024 · 9be8522 · 9be8522
1 parent ad02d16
commit 9be8522
Showing 1 changed file with 8 additions and 4 deletions.
diff --git a/...in/java/org/apache/shardingsphere/proxy/backend/util/DatabaseExportMetaDataGenerator.java b/...in/java/org/apache/shardingsphere/proxy/backend/util/DatabaseExportMetaDataGenerator.java
@@ -71,12 +71,16 @@ private void appendDataSourceConfigurations(final ShardingSphereDatabase databas
     private void appendDataSourceConfiguration(final String dataSourceName, final DataSourcePoolProperties props, final StringBuilder stringBuilder) {
         stringBuilder.append(createIndentation(2)).append(dataSourceName).append(':').append(System.lineSeparator());
         for (Entry<String, Object> entry : props.getConnectionPropertySynonyms().getStandardProperties().entrySet()) {
-            String value = null == entry.getValue() ? "" : entry.getValue().toString();
-            stringBuilder.append(createIndentation(4)).append(entry.getKey()).append(": ").append(value).append(System.lineSeparator());
+            if (null != entry.getValue()) {
+                String value = entry.getValue().toString();
+                stringBuilder.append(createIndentation(4)).append(entry.getKey()).append(": ").append(value).append(System.lineSeparator());
+            }
         }
         for (Entry<String, Object> entry : props.getPoolPropertySynonyms().getStandardProperties().entrySet()) {
-            String value = null == entry.getValue() ? "" : entry.getValue().toString();
-            stringBuilder.append(createIndentation(4)).append(entry.getKey()).append(": ").append(value).append(System.lineSeparator());
+            if (null != entry.getValue()) {
+                String value = entry.getValue().toString();
+                stringBuilder.append(createIndentation(4)).append(entry.getKey()).append(": ").append(value).append(System.lineSeparator());
+            }
         }
     }