Unique actual data nodes issue in sharding rule checker #34251
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strongduanmu
requested changes
Jan 5, 2025
| @@ -64,7 +64,7 @@ public void check(final ShardingRuleConfiguration ruleConfig) { | |||
|
|
|||
| private void checkUniqueActualDataNodesInTableRules() { | |||
| Collection<DataNode> uniqueActualDataNodes = new HashSet<>(shardingRule.getShardingTables().size(), 1F); | |||
| shardingRule.getShardingTables().forEach((key, value) -> checkUniqueActualDataNodes(uniqueActualDataNodes, key, value.getActualDataNodes().iterator().next())); | |||
| shardingRule.getShardingTables().forEach((key, value) -> value.getActualDataNodes().forEach(each -> checkUniqueActualDataNodes(uniqueActualDataNodes, key, each))); | |||
There was a problem hiding this comment.
If actualDataNodes contains many nodes, checking all nodes will take more time. Is it possible to add a props to control whether to check all actualDataNodes or sampleDataNode?
|
In addition, actualDataNodes are usually configured according to the same rules, so you only need to select sampleDataNode for verification without verifying all actualDataNodes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #ISSUSE_ID.
Changes proposed in this pull request:
In ShardingRuleChecker, while performing the check for Unique Actual Data Nodes, the initial check was performed for the first actualDataNode in the ShardingTable. Now, it has been changed to perform the check for every actualDataNode
Before committing this PR, I'm sure that I have checked the following options:
./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.