Split nativeTest modules for JDBC and Proxy #34358
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #29052.
Changes proposed in this pull request:
org.apache.shardingsphere.test.natived.proxy.transactions.base.SeataTest
will break Firebird unit tests in CI environment. This only happens under GraalVM Native Image. In order to investigate what exactly is the missing GraalVM reachability metadata JSON, it is necessary to raise the current PR.[ERROR] Metadata copy process failed with code: 1
is thrown when usingnative:metadata-copy
in a multi-module Maven project graalvm/native-build-tools#650 . Previously, the GRM JSON related toorg.apache.shardingsphere.mode.repository.standalone.jdbc.sql.JDBCRepositorySQL
only worked when the SS Proxy class was in the GraalVM Native Image. This was apparently because the judgment condition was not complete. Isolating the unit tests for JDBC and Proxy into different Maven modules is enough to handle this issue from a classpath perspective. Because the processing principle of GraalVM Tracing Agent is either based on classpath or module.Before committing this PR, I'm sure that I have checked the following options:
./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e
.