Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for connecting to Presto's Memory Connector in ShardingSphere config #34432

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

linghengqian
Copy link
Member

@linghengqian linghengqian commented Jan 22, 2025

For #29052.

Changes proposed in this pull request:

  • Support for connecting to Presto's Memory Connector in ShardingSphere config.
  • The current implementation does not record the table's index, primary keys, generated info, or column visibility. This obviously requires Presto to have a table like INFORMATION_SCHEMA.INDEXES. Presto Server's implementation of INFORMATION_SCHEMA.COLUMNS is also not perfect.
  • This PR was split from Add GraalVM Reachability Metadata and corresponding nativeTest for Presto #34429 for easier review.

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.
  • I have updated the Release Notes of the current development version. For more details, see Update Release Note

@linghengqian linghengqian added this to the 5.5.3 milestone Jan 22, 2025
@linghengqian linghengqian marked this pull request as ready for review January 22, 2025 15:05
@yx9o yx9o merged commit 1a4088f into apache:master Jan 22, 2025
147 checks passed
@linghengqian linghengqian deleted the presto-infra branch January 22, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants