This repository has been archived by the owner on Mar 25, 2024. It is now read-only.
Eureka Streams integration with Shindig pull request on the 2.0.x branch #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tup the iFrame's RPC channel. Particularly important when switching views of a gadget while staying on the same page.
…image configured for the main feed is available in the json returned to the gadget.
…ld for the gadget metadata. This is part of the gadget spec and makes sense to have available along with the other info that the JsonRpcHandler.java provides.
…ts in the json string output which causes the json parse method to throw a Syntax error. This is a problem for the requestNavigateTo rpc call because it includes optional arguments. If those arguments aren't supplied, they still get included in the output of stringify. This appears to only be a problem in IE7.
…nnel. Rather than skipping the setup if it appears to already be configured, when setupFrame is called always setup the frame.
|
hi, didn''t see this pull request (guess I'm not getting notified :( ) Is it still relevant? |
|
Not sure anymore, I have to check. Stephen Terlecki -----Original Message----- hi, didn''t see this pull request (guess I'm not getting notified :( ) Is it still relevant? Reply to this email directly or view it on GitHub: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are some modifications I needed to make to the Shindig baseline to support integration with Eureka Streams.
Should I create separate Jira tickets for each of these items?