Add go agent so11y dashboard #13074
Add go agent so11y dashboard #13074
Conversation
CodePrometheus
added
so11y
|
BTW, do we have go application in showcase? |
Yes. The rating service is a Go application that has agent enhancement. We should update it to the latest version in the showcase. @CodePrometheus |
| @@ -14,25 +14,28 @@ | |||
| # limitations under the License. | |||
|
|
|||
| {{- contains . }} | |||
| - id: {{ b64enc "localhost:-1" }}.0 | |||
There was a problem hiding this comment.
Why need to change the service list in E2E?
There was a problem hiding this comment.
Since the downstream works with the database, so I included the data.
There was a problem hiding this comment.
You removed consumer service, that is something different for the demo services.
There was a problem hiding this comment.
Why the previous one didn't fail the e2e? I am a little confused.
There was a problem hiding this comment.
maybe we use the {{- contains . }}? I tested it locally, found that adding VIRTUAL_DATABASE or removing e2e-service-consumer has no impact on the results.
There was a problem hiding this comment.
Is there any of this service existing? @mrproliu could you check e2e tooling?
I think once services matched, this PR is good.
CHANGESlog.Ref apache/skywalking-go#214