Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SOLR-17641: Disable the Security Manager for Java 24+ #3153

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

SOLR-17641: Disable the Security Manager for Java 24+ #3153

wants to merge 2 commits into from
+20 −2

Conversation

HoustonPutman
Copy link
Contributor

@github-actions github-actions bot added documentation Improvements or additions to documentation tool:build start-scripts labels Jan 31, 2025
uschindler
uschindler approved these changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@uschindler uschindler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested the Windows code, but looks fine in general.

I will update Policeman Jenkins to latest Java 24 tomorrow. We may need changes in Lucene, too.

@epugh
Copy link
Contributor

epugh commented Feb 1, 2025

It's great that you made the disabling conditional on Java 24+. I wonder though if we are better served just removing it completely from Solr 10, regardless of version of Java?

malliaridis
malliaridis reviewed Feb 3, 2025
View reviewed changes
Copy link
Contributor

@malliaridis malliaridis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested the Windows script schanges, works fine.

Can't build the project though with JDK 24 (ea).

malliaridis
malliaridis requested changes Feb 3, 2025
View reviewed changes
solr/bin/solr.cmd Outdated Show resolved Hide resolved
@HoustonPutman @malliaridis
Fix version check for windows
2244947 
Co-authored-by: Christos Malliaridis <[email protected]>
@madrob
Copy link
Contributor

madrob commented Feb 3, 2025

Agree with @epugh - isn't Security Manager all no-ops even with 21 (which IIRC is the minimum Java for Solr 10)

@HoustonPutman
Copy link
Contributor Author

Agree with @epugh - isn't Security Manager all no-ops even with 21 (which IIRC is the minimum Java for Solr 10)

I've never heard that. Do you have a link for that?

@uschindler
Copy link
Contributor

uschindler commented Feb 5, 2025 •
edited
Loading

Agree with @epugh - isn't Security Manager all no-ops even with 21 (which IIRC is the minimum Java for Solr 10)

I've never heard that. Do you have a link for that?

No, it isn't. It's fully working in 21. It gets a noop in 24 (actually Access controller). In addition, you can't configure it anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malliaridis malliaridis malliaridis requested changes

@uschindler uschindler uschindler approved these changes

@janhoy janhoy Awaiting requested review from janhoy

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation start-scripts tool:build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@HoustonPutman @epugh @madrob @uschindler @malliaridis