[SPARK-51033][CORE][TESTS] Fix CryptoStreamUtilsSuite to use sameElements for array comparison
#49727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lements` for array comparision
dongjoon-hyun
changed the title
CryptoStreamUtilsSuite to use sameElements for array comparisionCryptoStreamUtilsSuite to use sameElements for array comparison
LuciferYang
approved these changes
Jan 29, 2025
|
Thank you, @LuciferYang ! |
dongjoon-hyun
added a commit
that referenced
this pull request
Jan 29, 2025
…lements` for array comparison ### What changes were proposed in this pull request? This PR aims to fix `CryptoStreamUtilsSuite` to use `sameElements` for array comparison. ### Why are the changes needed? Since the existing assertion is invalid due to `String != Array[Byte]` comparison, it causes a compilation error from Scala 2.13.16. https://github.com/apache/spark/blob/6bbfa2dad8c70b94ca52eb7cddde5ec68efbe0b1/core/src/test/scala/org/apache/spark/security/CryptoStreamUtilsSuite.scala#L115 - #49478 ### Does this PR introduce _any_ user-facing change? No, this is a test-only fix. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #49727 from dongjoon-hyun/SPARK-51033. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 5cce6e9) Signed-off-by: Dongjoon Hyun <[email protected]>
dongjoon-hyun
added a commit
that referenced
this pull request
Jan 29, 2025
…lements` for array comparison ### What changes were proposed in this pull request? This PR aims to fix `CryptoStreamUtilsSuite` to use `sameElements` for array comparison. ### Why are the changes needed? Since the existing assertion is invalid due to `String != Array[Byte]` comparison, it causes a compilation error from Scala 2.13.16. https://github.com/apache/spark/blob/6bbfa2dad8c70b94ca52eb7cddde5ec68efbe0b1/core/src/test/scala/org/apache/spark/security/CryptoStreamUtilsSuite.scala#L115 - #49478 ### Does this PR introduce _any_ user-facing change? No, this is a test-only fix. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #49727 from dongjoon-hyun/SPARK-51033. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 5cce6e9) Signed-off-by: Dongjoon Hyun <[email protected]>
|
Merged to master/4.0/3.5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to fix
CryptoStreamUtilsSuiteto usesameElementsfor array comparison.Why are the changes needed?
Since the existing assertion is invalid due to
String != Array[Byte]comparison, it causes a compilation error from Scala 2.13.16.spark/core/src/test/scala/org/apache/spark/security/CryptoStreamUtilsSuite.scala
Line 115 in 6bbfa2d
Does this PR introduce any user-facing change?
No, this is a test-only fix.
How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
No.