chore(fe): migrate 6 Enzyme-based unit tests to RTL #31819
Conversation
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
I've completed my review and didn't find any issues.
Files scanned
| File Path | Reviewed |
|---|---|
| superset-frontend/src/components/ListViewCard/ImageLoader.tsx | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Need a new review? Comment
/korbit-reviewon this PR and I'll review your latest changes.Korbit Guide: Usage and Customization
Interacting with Korbit
- You can manually ask Korbit to review your PR using the
/korbit-reviewcommand in a comment at the root of your PR.- You can ask Korbit to generate a new PR description using the
/korbit-generate-pr-descriptioncommand in any comment on your PR.- Too many Korbit comments? I can resolve all my comment threads if you use the
/korbit-resolvecommand in any comment on your PR.- Chat with Korbit on issues we post by tagging @korbit-ai in your reply.
- Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.
Customizing Korbit
- Check out our docs on how you can make Korbit work best for you and your team.
- Customize Korbit for your organization through the Korbit Console.
Current Korbit Configuration
General Settings
Setting Value Review Schedule Automatic excluding drafts Max Issue Count 10 Automatic PR Descriptions ❌ Issue Categories
Category Enabled Naming ✅ Database Operations ✅ Documentation ✅ Logging ✅ Error Handling ✅ Systems and Environment ✅ Objects and Data Structures ✅ Readability and Maintainability ✅ Asynchronous Processing ✅ Design Patterns ✅ Third-Party Libraries ✅ Performance ✅ Security ✅ Functionality ✅ Feedback and Support
Note
Korbit Pro is free for open source projects 🎉
Looking to add Korbit to your team? Get started with a free 2 week trial here
hainenber
changed the title
hainenber
changed the title
superset-frontend/src/dashboard/components/gridComponents/Divider.test.jsx
Outdated
Show resolved
Hide resolved
| await act(async () => { | ||
| render(<ImageLoader {...defaultProps} />); | ||
| }); | ||
| expect(screen.getByTestId('image-loader')).toBeVisible(); |
There was a problem hiding this comment.
Can we replace using act with await screen.findByTestId? Same applies to other tests in this test suite
There was a problem hiding this comment.
yes, that's possible. TIL, thanks!
Refactored away in latest HEAD
|
Thanks! Re:CI, I think the 5th E2E test got borked after merging #31796 |
|
Probably just a flaky test, rerunning |
|
I checked e2e CI history. They all failed at 5th shard 🤔 |
|
The e2e test should be fixed now with #31933. Should just need a rebase. |
hainenber
requested review from
villebro,
geido,
eschutho,
betodealmeida,
nytai,
mistercrunch,
craig-rueda,
dpgaspar and
Antonio-RiveroMartnez
as code owners
github-actions
bot
added
i18n
github-actions
bot
added
github_actions
|
sheesh, rebase sheenanigans! Fixing in progress. Sorry for all folks getting notified! |
Signed-off-by: hainenber <[email protected]>
Signed-off-by: hainenber <[email protected]>
Signed-off-by: hainenber <[email protected]>
Signed-off-by: hainenber <[email protected]>
Co-authored-by: JUST.in DO IT <[email protected]>
Signed-off-by: hainenber <[email protected]>
hainenber
force-pushed
the
chores/migrate-enzyme-to-rtl
branch
from
ae34697 to
402fb80
Compare
github-actions
bot
removed
i18n
|
welp, I'm getting E2E CI failure in a different part now 🥲 |
|
Yeah, the e2e experience isnt the greatest right now… @geido @mistercrunch the Annotations „Create formula annotation y-axis goal line” is yet another test that’s been frequently failing for years. Would be great if one of us could take a look at that as a part of cypress cleanup project. |
chore(fe): migrate 6 Enzyme-based unit tests to RTL
SUMMARY
Part of ongoing Enzyme-to-RTL unit test migration. Also add types to a JSX-based unit test.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TESTING INSTRUCTIONS
All CIs should pass
ADDITIONAL INFORMATION