chore(tests): Trying to kill enzyme, part 2 (more RTL!) #32226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Based on your review schedule, I'll hold off on reviewing this PR until it's marked as ready for review. If you'd like me to take a look now, comment
|
rusackas
force-pushed
the
RTL-conversions-part-2
branch
from
0bc7a21 to
efb72a7
Compare
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review by Korbit AI
Korbit automatically attempts to detect when you fix issues in new commits.
| Category | Issue | Fix Detected |
|---|---|---|
 |
Redundant Inline Comment ▹ view | ✅ |
Files scanned
| File Path | Reviewed |
|---|---|
| superset-frontend/src/dashboard/components/menu/MarkdownModeDropdown.tsx | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Need a new review? Comment
/korbit-reviewon this PR and I'll review your latest changes.Korbit Guide: Usage and Customization
Interacting with Korbit
- You can manually ask Korbit to review your PR using the
/korbit-reviewcommand in a comment at the root of your PR.- You can ask Korbit to generate a new PR description using the
/korbit-generate-pr-descriptioncommand in any comment on your PR.- Too many Korbit comments? I can resolve all my comment threads if you use the
/korbit-resolvecommand in any comment on your PR.- Chat with Korbit on issues we post by tagging @korbit-ai in your reply.
- Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.
Customizing Korbit
- Check out our docs on how you can make Korbit work best for you and your team.
- Customize Korbit for your organization through the Korbit Console.
Feedback and Support
superset-frontend/src/dashboard/components/menu/MarkdownModeDropdown.tsx
Outdated
Show resolved
Hide resolved
justinpark
reviewed
Feb 12, 2025
superset-frontend/src/dashboard/components/menu/MarkdownModeDropdown.tsx
Outdated
Show resolved
Hide resolved
justinpark
reviewed
Feb 12, 2025
superset-frontend/src/dashboard/components/gridComponents/Markdown.test.jsx
Outdated
Show resolved
Hide resolved
justinpark
reviewed
Feb 12, 2025
superset-frontend/src/dashboard/components/gridComponents/Markdown.test.jsx
Outdated
Show resolved
Hide resolved
…opdown.tsx Co-authored-by: JUST.in DO IT <[email protected]>
…down.test.jsx Co-authored-by: JUST.in DO IT <[email protected]>
…down.test.jsx Co-authored-by: JUST.in DO IT <[email protected]>
…nto RTL-conversions-part-2
|
All green, if we're looking good here :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Moving a few more tests to RTL. Thanks Aider/Trae/Claude :)
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION