Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYNCOPE-1716] fixed membership hashmap multi-threaded problem with concurrent pull #571

Merged
merged 5 commits into from
Dec 10, 2023
Merged

[SYNCOPE-1716] fixed membership hashmap multi-threaded problem with concurrent pull #571

merged 5 commits into from
Dec 10, 2023

Conversation

flyueliu
Copy link
Contributor

@flyueliu flyueliu commented Dec 8, 2023

No description provided.

@ilgrosso
Copy link
Member

ilgrosso commented Dec 8, 2023

Thanks for your PR @flyueliu
Please ensure to fill, sign and send your ICLA before we can accept your contributions

fixed membership hashmap bug when task enable concurrent setting
973c017 
fixed membership hashmap bug when task enable concurrent setting

fixed membership hashmap bug when task enable concurrent setting
@flyueliu
Copy link
Contributor Author

flyueliu commented Dec 8, 2023

Thanks for your PR @flyueliu Please ensure to fill, sign and send your ICLA before we can accept your contributions

ok, i have send a email to [email protected]

@flyueliu flyueliu requested a review from ilgrosso December 8, 2023 17:47
@ilgrosso ilgrosso changed the title fixed membership hashmap multi threaded problem when task enable concurrent setting [SYNCOPE-1716] fixed membership hashmap multi-threaded problem with concurrent pull Dec 9, 2023
@ilgrosso
Copy link
Member

ilgrosso commented Dec 9, 2023

Thanks for your PR @flyueliu Please ensure to fill, sign and send your ICLA before we can accept your contributions

ok, i have send a email to [email protected]

Did you happen to ask the Syncope project to be notified? I can't seem to find anything yet in the records.

@flyueliu
Copy link
Contributor Author

flyueliu commented Dec 9, 2023

Thanks for your PR @flyueliu Please ensure to fill, sign and send your ICLA before we can accept your contributions

ok, i have send a email to [email protected]

Did you happen to ask the Syncope project to be notified? I can't seem to find anything yet in the records.

II did not fill in the notify project in my previous email, so I have now sent a new one

@ilgrosso
Copy link
Member

ilgrosso commented Dec 9, 2023

@flyueliu there is one unit test failure, please fix:

Error:    LDAPMembershipPullActionsTest.after:209 » NullPointer Cannot invoke "java.util.Set.add(Object)" because "memb" is null

@flyueliu flyueliu requested a review from ilgrosso December 9, 2023 17:15
@ilgrosso ilgrosso merged commit 920f51d into apache:master Dec 10, 2023
28 checks passed
ilgrosso pushed a commit that referenced this pull request Dec 10, 2023
@flyueliu @ilgrosso
[SYNCOPE-1716] fixed membership hashmap multi-threaded problem with c…
97d2ecd 
…oncurrent pull (#571)
@ilgrosso
Copy link
Member

Thank you very much @flyueliu
I've cherry-picked this PR to branch 3_0_X as 97d2ecd

@flyueliu
Copy link
Contributor Author

Thank you very much @flyueliu I've cherry-picked this PR to branch 3_0_X as 97d2ecd

I'm very glad to participate and thank you for your review. I benefited a lot from it. @ilgrosso

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilgrosso ilgrosso ilgrosso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@flyueliu @ilgrosso