Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NOJIRA: remove redundant throws; use parameterized logs #922

Merged
merged 3 commits into from
Nov 29, 2024
Merged

NOJIRA: remove redundant throws; use parameterized logs #922

merged 3 commits into from
Nov 29, 2024

Conversation

mmoayyed
Copy link
Contributor

This pull request presents the following changes:

  1. Removes redundant throws from the list of thrown exceptions where usually a parent or more generic exception exists already in the throws clause.
  2. Uses parameterized log messages instead of string concatenation

github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 28, 2024
View reviewed changes
.../provisioning-api/src/main/java/org/apache/syncope/core/provisioning/api/jexl/JexlUtils.java Dismissed Show dismissed Hide dismissed
.../provisioning-api/src/main/java/org/apache/syncope/core/provisioning/api/jexl/JexlUtils.java Dismissed Show dismissed Hide dismissed
fit/build-tools/src/main/java/org/apache/syncope/fit/buildtools/cxf/ProvisioningImpl.java Dismissed Show dismissed Hide dismissed
fit/build-tools/src/main/java/org/apache/syncope/fit/buildtools/cxf/ProvisioningImpl.java Dismissed Show dismissed Hide dismissed
fit/build-tools/src/main/java/org/apache/syncope/fit/buildtools/cxf/ProvisioningImpl.java Dismissed Show dismissed Hide dismissed
fit/build-tools/src/main/java/org/apache/syncope/fit/buildtools/cxf/ProvisioningImpl.java Dismissed Show dismissed Hide dismissed
@mmoayyed mmoayyed marked this pull request as ready for review November 29, 2024 11:06
@mmoayyed mmoayyed merged commit e51b14a into apache:master Nov 29, 2024
26 checks passed
@mmoayyed mmoayyed deleted the param-logs-redundant-throws branch November 29, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilgrosso ilgrosso ilgrosso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmoayyed @ilgrosso