Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYNCOPE-1854] Propagate changes for user update while pending approval #955

Conversation

leo-ccin2p3
Copy link
Contributor

allow propagation to external resources after form validation

allow propagation to external resources after form validation
@ilgrosso
Copy link
Member

Hi @leo-ccin2p3 can you please illustrate the rationale behind this proposed change?

@leo-ccin2p3
Copy link
Contributor Author

Hi @ilgrosso
In my BPMN workflow, I have implemented the ability to update certain attributes on a user which is already in status "updateApproved" (after the update the user will then stay in status "updateApprove").
This patch allows to propagate the change to the external resource in this case
Hope it's clear enough

@ilgrosso
Copy link
Member

Thanks for explanation @leo-ccin2p3
Please go ahead and open an issue on https://issues.apache.org/jira/ with the description as above (or even with more details if possible).
Once we have a JIRA issue, we will update this PR's title to include a reference to that.

Thank you!

@ilgrosso ilgrosso changed the title Update FlowableUserWorkflowAdapter.java [SYNCOPE-1854] Propagate changes for user update while pending approval Jan 16, 2025
@ilgrosso
Copy link
Member

I saw the JIRA issue, thanks.

If this is your very first contribution to The Apache Software foundation, please send your ICLA. thank you.

@ilgrosso
Copy link
Member

Adding a new test case or adjusting one of existing test cases under https://github.com/apache/syncope/blob/master/fit/core-reference/src/test/java/org/apache/syncope/fit/core/UserRequestITCase.java to check for this change would be nice.

@ilgrosso ilgrosso merged commit 16efca5 into apache:master Jan 17, 2025
26 checks passed
@ilgrosso
Copy link
Member

Thank you very much @leo-ccin2p3
I've also cherry-picked this to 3_0_X as 16efca5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants