-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYNCOPE-1855] Rewriting JPAAnySearchDAO to reduce subqueries #957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/dao/AnySearchNode.java
Fixed
Show fixed
Hide fixed
...sistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/dao/AnySearchNodeDAO.java
Fixed
Show fixed
Hide fixed
...sistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/dao/AnySearchNodeDAO.java
Fixed
Show fixed
Hide fixed
...sistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/dao/AnySearchNodeDAO.java
Fixed
Show fixed
Hide fixed
...sistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/dao/AnySearchNodeDAO.java
Fixed
Show fixed
Hide fixed
...sistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/dao/AnySearchNodeDAO.java
Fixed
Show fixed
Hide fixed
...sistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/dao/AnySearchNodeDAO.java
Fixed
Show fixed
Hide fixed
...sistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/dao/AnySearchNodeDAO.java
Fixed
Show fixed
Hide fixed
...sistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/dao/AnySearchNodeDAO.java
Fixed
Show fixed
Hide fixed
ojson current issue; the generated query is SELECT DISTINCT sv.any_id,sv.username
FROM user_search sv
WHERE (((plainSchema='fullname' AND ustringValue LIKE '%o%' ESCAPE '\' )
AND ((sv.any_id IN (
SELECT DISTINCT any_id FROM user_search_umembership WHERE group_id='37d15e4c-cdc1-460b-a591-8505c8133806')
OR sv.any_id IN (SELECT DISTINCT any_id FROM UDynGroupMembers WHERE group_id='37d15e4c-cdc1-460b-a591-8505c8133806'))))
AND (plainSchema='loginDate' AND JSON_VALUE(dateValue, '$[*]')='2009-05-26T00:00:00+02:00')
)
ORDER BY sv.username ASC but returns no results, while the amended SELECT DISTINCT sv.any_id,sv.username
FROM user_search sv
WHERE ((plainSchema='fullname' AND ustringValue LIKE '%o%' ESCAPE '\')
OR (plainSchema='loginDate' AND JSON_VALUE(dateValue, '$[*]')='2009-05-26T00:00:00+02:00'))
AND ((sv.any_id IN (
SELECT DISTINCT any_id FROM user_search_umembership WHERE group_id='37d15e4c-cdc1-460b-a591-8505c8133806')
OR sv.any_id IN (SELECT DISTINCT any_id FROM UDynGroupMembers WHERE group_id='37d15e4c-cdc1-460b-a591-8505c8133806')))
GROUP BY sv.any_id,sv.username
HAVING COUNT(*) = 2
ORDER BY sv.username ASC works as expected. The problem is recognizing sibling |
...rsistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/dao/JPAAnySearchDAO.java
Dismissed
Show dismissed
Hide dismissed
...rsistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/dao/JPAAnySearchDAO.java
Dismissed
Show dismissed
Hide dismissed
...rsistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/dao/JPAAnySearchDAO.java
Dismissed
Show dismissed
Hide dismissed
ilgrosso
changed the title
Rewriting JPAAnySearchDAO to reduce subqueries
[SYNCOPE-1855] Rewriting JPAAnySearchDAO to reduce subqueries
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
JPAAnySearchDAO
implementation is based on incrementally constructing the final query string.The new implementation is instead meant to build a tree representation and finally generating the query string from it.
The new implementation was initially provided asAnySearchNodeDAO
, not updatingJPAAnySearchDAO
yet to avoid build errors undercore/persistence-jpa-json
.TODO: