Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added TNonCopyable.h in favor of boost dependency #2276

Merged
merged 1 commit into from
Feb 12, 2021

Conversation

emmenlau
Copy link
Member

There is currently a thrift dependency on boost/noncopyable.hpp, but the design pattern of non-copyable base class is very small (only ~15 lines of code, including namespaces). To reduce the boost dependency (as discussed before), this PR adds a non-copyable base class pattern in its own header thrift/TNonCopyable.h.

  • Did you create an Apache Jira ticket? (not required for trivial changes)
  • If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • Did you squash your changes to a single commit? (not required, but preferred)
  • Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

@emmenlau emmenlau force-pushed the bda_add_noncopyable_base branch 2 times, most recently from bb8dcd4 to bc757d0 Compare November 25, 2020 16:10
@emmenlau
Copy link
Member Author

The Travis CI errors are unrelated, so this should be good for merge!

Copy link
Member

@zeshuai007 zeshuai007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Installing libboost_thread1.66 --2020-12-14 11:11:47-- http://cygwin.mirror.constant.com//x86_64/release/boost/libboost_thread1.66/libboost_thread1.66-1.66.0-1.tar.xz Resolving cygwin.mirror.constant.com (cygwin.mirror.constant.com)... 108.61.5.83 Connecting to cygwin.mirror.constant.com (cygwin.mirror.constant.com)|108.61.5.83|:80... connected. HTTP request sent, awaiting response... 200 OK Length: 33572 (33K) [application/octet-stream] Saving to: ‘libboost_thread1.66-1.66.0-1.tar.xz’ 0K .......... .......... .......... .. 100% 875K=0.04s 2020-12-14 11:11:48 (875 KB/s) - ‘libboost_thread1.66-1.66.0-1.tar.xz’ saved [33572/33572] libboost_thread1.66-1.66.0-1.tar.xz: OK Unpacking... /usr/bin/apt-cyg: line 442: 1331 Segmentation fault tar -x -C / -f $bn Package libboost_thread1.66 requires the following packages, installing: cygwin libboost_system1.66 libgcc1 libstdc++6 Package cygwin is already installed, skipping Package libboost_system1.66 is already installed, skipping Package libgcc1 is already installed, skipping Package libstdc++6 is already installed, skipping Package libgcc1 is already installed, skipping Package libstdc++6 is already installed, skipping

Ci looks like failed by unpack libboost_thread1.66.tar.xz fail.
I've created an issue to report it to them.
transcode-open/apt-cyg#139

@emmenlau
Copy link
Member Author

Ci looks like failed by unpack libboost_thread1.66.tar.xz fail.
I've created an issue to report it to them.
transcode-open/apt-cyg#139

Thanks a lot! But the error did not happen in other PRs that where triggered at the same time. So I assume it must be a slightly random thing (in other words, failed download or bad mirror or something?)

@zeshuai007
Copy link
Member

So I assume it must be a slightly random thing (in other words, failed download or bad mirror or something?)

Agree.

@emmenlau
Copy link
Member Author

Rebased on latest master. I plan to merge this PR (if CI remains green against latest master).

@emmenlau emmenlau merged commit 102e834 into apache:master Feb 12, 2021
@emmenlau emmenlau deleted the bda_add_noncopyable_base branch February 12, 2021 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants