-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added TNonCopyable.h in favor of boost dependency #2276
Added TNonCopyable.h in favor of boost dependency #2276
Conversation
bb8dcd4
to
bc757d0
Compare
The Travis CI errors are unrelated, so this should be good for merge! |
bc757d0
to
98e0660
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Installing libboost_thread1.66 --2020-12-14 11:11:47-- http://cygwin.mirror.constant.com//x86_64/release/boost/libboost_thread1.66/libboost_thread1.66-1.66.0-1.tar.xz Resolving cygwin.mirror.constant.com (cygwin.mirror.constant.com)... 108.61.5.83 Connecting to cygwin.mirror.constant.com (cygwin.mirror.constant.com)|108.61.5.83|:80... connected. HTTP request sent, awaiting response... 200 OK Length: 33572 (33K) [application/octet-stream] Saving to: ‘libboost_thread1.66-1.66.0-1.tar.xz’ 0K .......... .......... .......... .. 100% 875K=0.04s 2020-12-14 11:11:48 (875 KB/s) - ‘libboost_thread1.66-1.66.0-1.tar.xz’ saved [33572/33572] libboost_thread1.66-1.66.0-1.tar.xz: OK Unpacking... /usr/bin/apt-cyg: line 442: 1331 Segmentation fault tar -x -C / -f $bn Package libboost_thread1.66 requires the following packages, installing: cygwin libboost_system1.66 libgcc1 libstdc++6 Package cygwin is already installed, skipping Package libboost_system1.66 is already installed, skipping Package libgcc1 is already installed, skipping Package libstdc++6 is already installed, skipping Package libgcc1 is already installed, skipping Package libstdc++6 is already installed, skipping
Ci looks like failed by unpack libboost_thread1.66.tar.xz fail.
I've created an issue to report it to them.
transcode-open/apt-cyg#139
Thanks a lot! But the error did not happen in other PRs that where triggered at the same time. So I assume it must be a slightly random thing (in other words, failed download or bad mirror or something?) |
Agree. |
98e0660
to
d03d8f0
Compare
d03d8f0
to
75b9fa6
Compare
Rebased on latest master. I plan to merge this PR (if CI remains green against latest master). |
75b9fa6
to
d270b35
Compare
There is currently a thrift dependency on
boost/noncopyable.hpp
, but the design pattern of non-copyable base class is very small (only ~15 lines of code, including namespaces). To reduce the boost dependency (as discussed before), this PR adds a non-copyable base class pattern in its own headerthrift/TNonCopyable.h
.[skip ci]
anywhere in the commit message to free up build resources.