Skip to content

Commit

Permalink
ConnectionTracker: Remove queue implementation (#10825)
Browse files Browse the repository at this point in the history
Connection count queueing functionality was removed via #7302. This
removes some dead code that was still associated with that now-removed
feature.
  • Loading branch information
bneradt authored Nov 18, 2023
1 parent de9970c commit 03ad26e
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 24 deletions.
21 changes: 0 additions & 21 deletions include/iocore/net/ConnectionTracker.h
Original file line number Diff line number Diff line change
Expand Up @@ -169,10 +169,6 @@ class ConnectionTracker
int reserve();
/// Release a connection reservation.
void release();
/// Reserve a queue / retry slot.
int enqueue();
/// Release a block
void dequeue();
/// Note blocking a transaction.
void blocked();
/// Clear all reservations.
Expand Down Expand Up @@ -355,27 +351,10 @@ ConnectionTracker::TxnState::drop()
return std::move(_g);
}

inline int
ConnectionTracker::TxnState::enqueue()
{
_queued_p = true;
return ++_g->_in_queue;
}

inline void
ConnectionTracker::TxnState::dequeue()
{
if (_queued_p) {
_queued_p = false;
--_g->_in_queue;
}
}

inline void
ConnectionTracker::TxnState::clear()
{
if (_g) {
this->dequeue();
this->release();
_g = nullptr;
}
Expand Down
3 changes: 0 additions & 3 deletions src/proxy/http/HttpSM.cc
Original file line number Diff line number Diff line change
Expand Up @@ -5884,9 +5884,6 @@ HttpSM::handle_post_failure()
void
HttpSM::handle_http_server_open()
{
// The request is now not queued. This is important because server retries reuse the t_state.
t_state.outbound_conn_track_state.dequeue();

// [bwyatt] applying per-transaction OS netVC options here
// IFF they differ from the netVC's current options.
// This should keep this from being redundant on a
Expand Down

0 comments on commit 03ad26e

Please sign in to comment.