Cleanup P_SNIActionPerformer (#10727)

Move function definitions into the .cc file so the hedaer file doesn't bring unrelated dependencies.
apache · Nov 6, 2023 · 0c47100 · 0c47100
1 parent 4d176c0
commit 0c47100
Show file tree

Hide file tree

Showing 11 changed files with 639 additions and 588 deletions.
diff --git a/include/iocore/net/SNIActionPerformer.h → include/iocore/net/SNIActionItem.h b/include/iocore/net/SNIActionPerformer.h → include/iocore/net/SNIActionItem.h
@@ -32,7 +32,8 @@
 
 #include <vector>
 #include <optional>
-#include "iocore/net/TLSSNISupport.h"
+#include <openssl/ssl.h>
+
 #include "tscore/ink_inet.h"
 #include "ts/DbgCtl.h"
 

diff --git a/include/iocore/net/SSLSNIConfig.h b/include/iocore/net/SSLSNIConfig.h
@@ -40,7 +40,7 @@
 #include "tscpp/util/ts_ip.h"
 
 #include "iocore/eventsystem/ConfigProcessor.h"
-#include "iocore/net/SNIActionPerformer.h"
+#include "iocore/net/SNIActionItem.h"
 #include "iocore/net/YamlSNIConfig.h"
 
 #include <functional>

diff --git a/include/iocore/net/YamlSNIConfig.h b/include/iocore/net/YamlSNIConfig.h
@@ -29,7 +29,6 @@
 #include <memory>
 #include <cstdint>
 
-#include "iocore/net/SNIActionPerformer.h"
 #include "iocore/net/SSLTypes.h"
 
 #include "tscpp/util/ts_ip.h"
@@ -74,6 +73,8 @@ TSDECL(http2_initial_window_size_in);
 TSDECL(server_max_early_data);
 #undef TSDECL
 
+class ActionItem;
+
 struct YamlSNIConfig {
   enum class Policy : uint8_t { DISABLED = 0, PERMISSIVE, ENFORCED, UNSET };
   enum class Property : uint8_t { NONE = 0, SIGNATURE_MASK = 0x1, NAME_MASK = 0x2, ALL_MASK = 0x3, UNSET };

diff --git a/src/iocore/net/P_Connection.h b/src/iocore/net/P_Connection.h
@@ -50,6 +50,7 @@
 #pragma once
 
 #include "tscore/ink_platform.h"
+#include "iocore/net/NetProcessor.h"
 
 struct NetVCOptions;