[YUNIKORN-2392] Ensure scheduling tasks are accessed under lock (#784)

Concurrent map write detected during performance testing only. The code has been through all unit and e2e tested and none have triggered the concurrent write. No test cases added. Closes: #784 Signed-off-by: Wilfred Spiegelenburg <[email protected]>
apache · Feb 9, 2024 · e901279 · e901279
1 parent 5f8d20b
commit e901279
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/pkg/cache/external/scheduler_cache.go b/pkg/cache/external/scheduler_cache.go
@@ -375,8 +375,10 @@ func (cache *SchedulerCache) removePriorityClass(priorityClass *schedulingv1.Pri
 // NotifyTaskSchedulerAction registers the fact that a task has been evaluated for scheduling, and consequently the
 // scheduler plugin should move it to the activeQ if requested to do so.
 func (cache *SchedulerCache) NotifyTaskSchedulerAction(taskID string) {
+	cache.lock.Lock()
+	defer cache.lock.Unlock()
 	// verify that the pod exists in the cache, otherwise ignore
-	if _, ok := cache.GetPod(taskID); !ok {
+	if _, ok := cache.GetPodNoLock(taskID); !ok {
 		return
 	}
 	cache.addSchedulingTask(taskID)