Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-2850] Watch configmap only in yunikorn's deployed namespace #957

Closed
wants to merge 1 commit into from

Conversation

kousei47747
Copy link

What is this PR for?

Currently, Yunikorn uses configmap informer to handle configuration hot reload.

However, In current implementation informer watches all namespaces even only need to watch namespace in which yunikorn is deployed. It causes in efficient behavior when sync and cache configmap states. If there is too many unrelated configmap in other namespace cause long recovery time to list and memory presure to handle configmap caches which is redundant.

So, If we could replace configmap informer to namespace restricted one, it would improve startup / recovery time and reduce memory usage.

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-2850

@kousei47747 kousei47747 changed the title Watch configmap only in yunikorn's deployed namespace [YUNIKORN-2850] Watch configmap only in yunikorn's deployed namespace Mar 5, 2025
Copy link

codecov bot commented Mar 5, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 67.99%. Comparing base (0cf3c81) to head (cc593a0).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/client/apifactory.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #957      +/-   ##
==========================================
+ Coverage   67.96%   67.99%   +0.03%     
==========================================
  Files          72       72              
  Lines        9261     9261              
==========================================
+ Hits         6294     6297       +3     
+ Misses       2756     2754       -2     
+ Partials      211      210       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@craigcondit craigcondit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants