Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-2424] Expose checksums for reproducible builds #171

Closed
wants to merge 2 commits into from

Conversation

craigcondit
Copy link
Contributor

@craigcondit craigcondit commented Feb 16, 2024

What is this PR for?

As part of generating the release source archive, speculatively
generate build artifacts and embed the resultant checksums in the
README.md for the release.

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-2424

How should this be tested?

Screenshots (if appropriate)

Questions:

  • - The licenses files need update.
  • - There is breaking changes for older versions.
  • - It needs documentation.

@craigcondit craigcondit self-assigned this Feb 16, 2024
As part of generating the release source archive, speculatively
generate build artifacts and embed the resultant checksums in the
README.md for the release.
@craigcondit craigcondit marked this pull request as ready for review February 20, 2024 04:02
Copy link
Contributor

@wilfred-s wilfred-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes: v8 needs to be dropped

release-top-level-artifacts/README.md Outdated Show resolved Hide resolved
release-top-level-artifacts/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@pbacsko pbacsko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

@craigcondit craigcondit deleted the YUNIKORN-2424 branch February 20, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants