[YUNIKORN-1974] Move to Node.js 18 (#334)

Node.js 16 has reached its End-of-Life as of September 11, 2023. Moving to Node 18.17 as the current latest LTS version Closes: #334 Signed-off-by: Wilfred Spiegelenburg <[email protected]>
apache · Oct 17, 2023 · 8e6e72a · 8e6e72a
1 parent 70ad1f0
commit 8e6e72a
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/.github/workflows/auto-publish.yml b/.github/workflows/auto-publish.yml
@@ -31,7 +31,7 @@ jobs:
       - name: "Build and run website locally"
         working-directory: './yunikorn-master'
         run: |
-          NODE_VERSION=$(cat .nvmrc) && NODE_VERSION=${NODE_VERSION:-16.14}
+          NODE_VERSION=$(cat .nvmrc) && NODE_VERSION=${NODE_VERSION:-18.17}
           git log master --pretty=format:"Auto refresh: %s" -n 1 > ../asf-site-commit.txt
           docker build -t yunikorn/yunikorn-website:2.0.0 . --build-arg NODE_VERSION=${NODE_VERSION}
           docker run --name yunikorn-site -d -p 3000:3000 yunikorn/yunikorn-website:2.0.0

diff --git a/.github/workflows/pre-commit.yml b/.github/workflows/pre-commit.yml
@@ -32,5 +32,5 @@ jobs:
         run: ./check_license.sh
       - name: Build the site image
         run: |
-          NODE_VERSION=$(cat .nvmrc) && NODE_VERSION=${NODE_VERSION:-16.14}
+          NODE_VERSION=$(cat .nvmrc) && NODE_VERSION=${NODE_VERSION:-18.17}
           docker build -t yunikorn/yunikorn-website:2.0.0 . --build-arg NODE_VERSION=${NODE_VERSION}
diff --git a/.nvmrc b/.nvmrc
@@ -1 +1 @@
-16.16
+18.17
diff --git a/local-build.sh b/local-build.sh
@@ -36,8 +36,8 @@ function node_version() {
   if [ -r ${NV_FILE} ]; then
     NODE_VERSION=$(<"$NV_FILE")
   fi
-  # docusausrus 2.0.0-beta.18 and later ony work with node 16.14 later, use it as the default
-  NODE_VERSION=${NODE_VERSION:-16.14}
+  # docusausrus 2.0.0-beta.18 and later only work with node 16.14 later, we use latest LTS as default.
+  NODE_VERSION=${NODE_VERSION:-18.17}
 }
 
 function image_build() {