[YUNIKORN-970] Add queue metrics with queue names as labels #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yzhangal
approved these changes
Nov 10, 2023
There was a problem hiding this comment.
Thanks @WilliamTom for working on this. It looks good to me. +1 (non-binding)
|
LGTM, thanks Will, I will merge it. |
wilfred-s
pushed a commit
that referenced
this pull request
Nov 20, 2023
Reverted as part of the YuniKorn 1.4 release steps and re-published after versioning documentation under a new commit to master. Co-authored-by: William Tom <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
1.5.01.6.0) and removal (1.7.0) notices for the subsystem metrics that are being replacedWhat type of PR is it?
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-970
How should this be tested?
Local build with
./local-build.sh runScreenshots (if appropriate)
Questions: