Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-2228] Fix doc admissionController.filtering.defaultQueue default should be root.default #377

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

brandboat
Copy link
Member

What is this PR for?

in https://yunikorn.apache.org/docs/next/user_guide/service_config/#admissioncontrollerfilteringdefaultqueue

admissionController.filtering.defaultQueue default value should be root.default instead of empty. (see https://github.com/apache/yunikorn-k8shim/blob/28995cd7289256be3d3b8f820d438ddec36778b3/pkg/admission/conf/am_conf.go#L76)

What type of PR is it?

  • - Bug Fix

Todos

N/A

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-2228

How should this be tested?

N/A

Screenshots (if appropriate)

N/A

Questions:

N/A

Copy link
Member

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chia7712 chia7712 merged commit 78b58df into apache:master Dec 5, 2023
1 check passed
@brandboat brandboat deleted the YUNIKORN-2228 branch December 5, 2023 08:29
github-actions bot pushed a commit that referenced this pull request Dec 5, 2023
github-actions bot pushed a commit to yangwwei/yunikorn-site that referenced this pull request Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants