Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[YUNIKORN-2337] Update documentation about event streaming #401

Closed
wants to merge 1 commit into from
Closed

[YUNIKORN-2337] Update documentation about event streaming #401

wants to merge 1 commit into from

Conversation

pbacsko
Copy link
Contributor

@pbacsko pbacsko commented Feb 20, 2024

What is this PR for?

REST endpoint documentation about event streaming.

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-2337

How should this be tested?

Screenshots (if appropriate)

Questions:

  • - The licenses files need update.
  • - There is breaking changes for older versions.
  • - It needs documentation.

@pbacsko pbacsko self-assigned this Feb 20, 2024
chia7712
chia7712 approved these changes Feb 21, 2024
View reviewed changes
Copy link
Member

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I have an unrelated question: How to observe/get the current connections? For example, users can observe the connection/hosts by restful APIs?

@pbacsko
Copy link
Contributor Author

pbacsko commented Feb 21, 2024

LGTM

I have an unrelated question: How to observe/get the current connections? For example, users can observe the connection/hosts by restful APIs?

The state dump contains the active streaming connections.

wilfred-s
wilfred-s approved these changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@wilfred-s wilfred-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wilfred-s wilfred-s closed this in 2801670 Feb 21, 2024
github-actions bot pushed a commit that referenced this pull request Feb 21, 2024
@yunikorn-bot
Auto refresh: [YUNIKORN-2337] Update documentation about event stream…
e95bfb5 
…ing (#401)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chia7712 chia7712 chia7712 approved these changes

@wilfred-s wilfred-s wilfred-s approved these changes

@manirajv06 manirajv06 Awaiting requested review from manirajv06

Assignees

@pbacsko pbacsko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pbacsko @chia7712 @wilfred-s