[YUNIKORN-2481] Convert yunikorn-site to use pnpm

[craigcondit]

What is this PR for?

Use pnpm instead of yarn for yunikorn-site. This results in a much faster, more reliable build.

• Update build scripts to use pnpm for dependency management
• Ensure node_modules is not shared between Docker and host
• Update Dockerfile to allow pre-caching pnpm dependencies

What type of PR is it?

• - Bug Fix
• - Improvement
• - Feature
• - Documentation
• - Hot Fix
• - Refactoring

Todos

• - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-2481

How should this be tested?

Screenshots (if appropriate)

Questions:

• - The licenses files need update.
• - There is breaking changes for older versions.
• - It needs documentation.

[craigcondit]

Most of the weirdness in the old build was due to node_modules being (incorrectly) shared between the host and the Docker environment. This has been fixed and the build steps re-ordered to allow caching intermediate Docker steps as long as dependencies have not changed. This should also eliminate the need to explicitly add the algolia search theme every time.

We also now check-in the lock file (like we do for other projects) so that we have consistent builds from one run to another.

[chenyulin0719]

Most of the changes looks good, tested in local and docker.

One more minor change required:

• yarn.lock in .gitignore could be removed. (https://github.com/apache/yunikorn-site/blob/master/.gitignore#L9)

[chenyulin0719]

It isolated the host's and docker's node_modules/ .
Could I confirm what is the previous weirdness in the old build? I wasn't aware of it before.

Most of the weirdness in the old build was due to node_modules being (incorrectly) shared between the host and the Docker environment.

[chenyulin0719]

I think it would be better if we can explain the reason under run_base()'s comments.
ex:

function run_base() {
  # run docker container
  # mount the repo root to the container working dir,
  # so that changes made in the repo can trigger the web-server auto-update
  # Also prevent sharing node_modules/ between the host and the Docker environment to avoid potential conflict.

[craigcondit]

Docker behavior is well documented already and I'd rather not clutter a simple function with a large comment here.

[craigcondit]

It isolated the host's and docker's node_modules/ .

Could I confirm what is the previous weirdness in the old build? I wasn't aware of it before.

Most of the weirdness in the old build was due to node_modules being (incorrectly) shared between the host and the Docker environment.

We had all sorts of strange brokenness around algolia search having to be reinstalled constantly. I suspect there was platform-specific code being added and this caused issues when node_modules was shared between different platforms.

[craigcondit]

Most of the changes looks good, tested in local and docker.

One more minor change required:

• yarn.lock in .gitignore could be removed. (https://github.com/apache/yunikorn-site/blob/master/.gitignore#L9)

I'd rather leave this in to prevent committing the lock file accidentally by other users since we previously used yarn. There will be many devs with old yarn lock files in their trees.

@chenyulin0719 see my comments and please re-review.

[chenyulin0719]

+1 LGTM