Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-2400] Upgrade docusaurus to 3.2 #421

Closed
wants to merge 7 commits into from

Conversation

ryankert01
Copy link
Contributor

@ryankert01 ryankert01 commented Apr 9, 2024

What is this PR for?

migrate docusaurus to v3.2 based on the migration guide.

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

Todos

N/A

What is the Jira issue?

YUNIKORN-2400

How should this be tested?

./local-build.sh run
 docker build -t yunikorn/yunikorn-website:2.0.0 . --build-arg NODE_VERSION=18.19

Screenshots (if appropriate)

Screenshot 2024-04-09 at 7 31 50 PM

Questions:

N/A

@ryankert01
Copy link
Contributor Author

Github Action omits an error indicating a problem that exists on the master branch(when you click on the people link in the footer section, 404 emerged), aka. resolve to the wrong url.

@ryankert01
Copy link
Contributor Author

Actually, if you click a lot of times, it will become this:

https://yunikorn.apache.org/community/community/community/community/community/community/community/people

@ryankert01
Copy link
Contributor Author

It's a tiny bug. I change href to to to solve it. Also, @steinsgateted can you help me re-run the github workflow? Thanks.

@ryankert01
Copy link
Contributor Author

Hi, @wilfred-s , I hope this message finds you well. When you have a moment, could you please review my pr? I believe it addresses our mission to migrate docusaurus to v3.2. Your feedback would be greatly appreciated to move this forward.

Thank you for your time and assistance.

@chenyulin0719 chenyulin0719 self-requested a review April 19, 2024 05:13
Copy link
Contributor

@chenyulin0719 chenyulin0719 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, summary the compatibility changes in this PR.

  1. Escape '{', '}', '<' when it's just used as a character. (Link)
  2. Versioned Sidebars fixed. (Link)

github-actions bot pushed a commit to pbacsko/incubator-yunikorn-site that referenced this pull request Apr 28, 2024
github-actions bot pushed a commit to chia7712/yunikorn-site that referenced this pull request May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants