[YUNIKORN-2696] Appoint specific version when installing yunikorn

[Paul-Lyu]

What is this PR for?

Appoint specific version when installing yunikorn
In get started doc, image tags are latest which is not available on docker hub.

What type of PR is it?

• - Bug Fix
• - Improvement
• - Feature
• - Documentation
• - Hot Fix
• - Refactoring

Todos

• - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-2696

How should this be tested?

Screenshots (if appropriate)

Questions:

• - The licenses files need update.
• - There is breaking changes for older versions.
• - It needs documentation.

[craigcondit]

I don't think we should hardcode a specific version here. This will get out-of-date quickly. Instead, reference the tags as "scheduler-{version}" and point users to DockerHub for available tags.

Also, drop reference to 'latest'. 'docker hub' should be 'DockerHub', and 'Yunikorn' should be 'YuniKorn'.

[craigcondit]

See previous comment.

[chia7712]

I don't think we should hardcode a specific version here. This will get out-of-date quickly. Instead, reference the tags as "scheduler-{version}" and point users to DockerHub for available tags.

agree. This PR can align the example of https://github.com/apache/yunikorn-site/blob/master/docs/user_guide/service_config.md?plain=1#L39

'Yunikorn' should be 'YuniKorn'.

There are many such typo in code base. Maybe we should fix it. at least yunikorn-site repo

[ryankert01]

I don't think we should hardcode a specific version here. This will get out-of-date quickly. Instead, reference the tags as "scheduler-{version}" and point users to DockerHub for available tags.

agree. This PR can align the example of https://github.com/apache/yunikorn-site/blob/master/docs/user_guide/service_config.md?plain=1#L39

I agree; we can align this method with all versioned examples in the docs.

[wilfred-s]

LGTM, I think all requested changes are done

[chia7712]

@Paul-Lyu thanks for updates. Could you please update https://github.com/apache/yunikorn-site/blob/master/docs/user_guide/service_config.md#container-images too?

[chenyulin0719]

Sorry for the late review.
Instead of providing a custom.yml, I would prefer to use a single command. (Refer the chart configuration list)

EX:

VERSION=1.5.2
helm install yunikorn yunikorn/yunikorn --namespace yunikorn \
  --set image.tag=scheduler-${VERSION} \
  --set pluginImage.tag=scheduler-plugin-${VERSION} 
  --set admissionController.image.tag=admission-${VERSION} \
  --set web.image.tag=web-${VERSION}

The even better solution is to extract variable version in helm's values.yml, so we could use:

VERSION=1.5.2
helm install yunikorn yunikorn/yunikorn --namespace yunikorn \
  --set version=${VERSION}

If anyone agree with me, we can create a new Jira for the improvement.

[chenyulin0719]

LGTM. Since this PR already addresses the request, I will merge it later today.

[blueBlue0102]

Sorry for the late review. Instead of providing a custom.yml, I would prefer to use a single command. (Refer the chart configuration list)
...
...
The even better solution is to extract variable version in helm's values.yml, so we could use:

VERSION=1.5.2
helm install yunikorn yunikorn/yunikorn --namespace yunikorn \
  --set version=${VERSION}

If anyone agree with me, we can create a new Jira for the improvement.

I agree with @chenyulin0719; using a single command is more convenient than providing a custom.yml.

[chia7712]

using a single command is more convenient than providing a custom.yml.

sounds good to me

[chenyulin0719]

Created the followup Jira: [YUNIKORN-2819] Add version parameter to Helm chart