Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-2749] Place all observability related doc in same directory #465

Merged
merged 2 commits into from
Aug 26, 2024

Conversation

mean-world
Copy link
Contributor

What is this PR for?

This pr put observability related doc in a category
Help user can quickly find out observability doc of YUNIKORN

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-2749

@0yukali0
Copy link
Contributor

0yukali0 commented Aug 25, 2024

Hi @mean-world
Thanks for contribution.
pre-commit workflow failed because of a broken link where is at get_started doc.
I believes workflow will pass after fix the broken link.
Following figure is after updating the link.
image

Copy link
Contributor

@0yukali0 0yukali0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

Copy link
Contributor

@chenyulin0719 chenyulin0719 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0yukali0 0yukali0 merged commit 3082d30 into apache:master Aug 26, 2024
1 check passed
github-actions bot pushed a commit that referenced this pull request Aug 26, 2024
@mean-world mean-world deleted the YUNIKORN-2749 branch August 28, 2024 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants