Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-2890] fix broken table in "Labels and Annotations in YuniKorn" page #473

Closed
wants to merge 2 commits into from

Conversation

ryankert01
Copy link
Contributor

What is this PR for?

refer to https://yunikorn.apache.org/docs/user_guide/labels_and_annotations_in_yunikorn#labels-in-yunikorn

Before:
截圖 2024-09-26 凌晨2 15 28

After
截圖 2024-09-26 凌晨2 16 26

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-2890

How should this be tested?

Screenshots (if appropriate)

Questions:

  • - The licenses files need update.
  • - There is breaking changes for older versions.
  • - It needs documentation.

Copy link
Contributor

@chenyulin0719 chenyulin0719 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing out the issue, we should also update the versioned page of 1.6.0.

docs/user_guide/labels_and_annotations_in_yunikorn.md Outdated Show resolved Hide resolved
@ryankert01 ryankert01 changed the title [YUNIKORN-2890] fix the table in Lebals section is broken [YUNIKORN-2890] fix broken table in Lebels section Sep 26, 2024
Copy link
Contributor

@chenyulin0719 chenyulin0719 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LTGM

@chenyulin0719 chenyulin0719 changed the title [YUNIKORN-2890] fix broken table in Lebels section [YUNIKORN-2890] fix broken table in "Labels and Annotations in YuniKorn" page Sep 26, 2024
@ryankert01 ryankert01 deleted the YUNIKORN-2890 branch September 26, 2024 10:39
github-actions bot pushed a commit that referenced this pull request Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants