Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-2899] chore: update node version to LTS, update package and solve warnings #476

Closed
wants to merge 5 commits into from

Conversation

ryankert01
Copy link
Contributor

@ryankert01 ryankert01 commented Oct 4, 2024

What is this PR for?

  1. Browserslist: caniuse-lite is outdated. Please run:
    npx update-browserslist-db@latest
    Why you should do it regularly: https://github.com/browserslist/update-db#readme
  2. update docusaurous to v3.5.2
  3. resolve security warnings
  4. update node version to latest LTS version
  5. add a pnpm run serve for serving local built.

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-2899

How should this be tested?

tested with:

  1. ./local-build.sh run
  2. pnpm build

need test: github ci

Screenshots (if appropriate)

Questions:

  • - The licenses files need update.
  • - There is breaking changes for older versions.
  • - It needs documentation.

@ryankert01 ryankert01 marked this pull request as ready for review October 4, 2024 15:44
Copy link
Contributor

@craigcondit craigcondit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm -1 on using 'lts' as a version ID. This doesn't allow us to have reproducible builds.

@ryankert01
Copy link
Contributor Author

ryankert01 commented Oct 4, 2024

Hi @craigcondit, thanks for your review.
Make sense, I'll use 20.17 then.

@ryankert01 ryankert01 requested a review from craigcondit October 4, 2024 18:21
Copy link
Contributor

@craigcondit craigcondit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the default version in the github action as well.

Copy link
Contributor

@craigcondit craigcondit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also update .github/workflows/pre-commit.yml.

@ryankert01 ryankert01 requested a review from craigcondit October 4, 2024 18:51
@ryankert01
Copy link
Contributor Author

Hi @craigcondit, just updated it and tested docker build with it.

@craigcondit
Copy link
Contributor

Still missing updates to pre-commit.yml.

@ryankert01
Copy link
Contributor Author

Gotcha!

Copy link
Contributor

@craigcondit craigcondit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM.

@ryankert01 ryankert01 deleted the YUNIKORN-2899 branch October 4, 2024 19:07
github-actions bot pushed a commit that referenced this pull request Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants