-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[YUNIKORN-2899] chore: update node version to LTS, update package and solve warnings #476
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm -1 on using 'lts' as a version ID. This doesn't allow us to have reproducible builds.
Hi @craigcondit, thanks for your review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the default version in the github action as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also update .github/workflows/pre-commit.yml.
Hi @craigcondit, just updated it and tested docker build with it. |
Still missing updates to pre-commit.yml. |
Gotcha! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 LGTM.
What is this PR for?
npx update-browserslist-db@latest
Why you should do it regularly: https://github.com/browserslist/update-db#readme
pnpm run serve
for serving local built.What type of PR is it?
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-2899
How should this be tested?
tested with:
./local-build.sh run
pnpm build
need test: github ci
Screenshots (if appropriate)
Questions: