-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[YUNIKORN-2903]modify Dev Environment Setup ServiceAccount token generate guide #492
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall lgtm, some minors. We can eliminate 3. actually.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Please at least cover our latest v1.6.0 versioned docs also. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By default, the default
service account has no permission to view pods.
The developer must bind cluster role to the account, please check below document.
- https://github.com/kubernetes/dashboard/blob/master/docs/user/access-control/creating-sample-user.md
We could just put the link as reference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment left below. And could you please update v1.6.0 versioned docs too. It would be helpful for the new developers.
done, pls check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please also update assets
update assets ok |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 LGTM
… for accessing K8S dashboard (#492)
What is this PR for?
modify k8s dashboard token generation part. According to https://stackoverflow.com/questions/76133984/kubernetes-service-account-doesnt-have-token, k8s service account don't generate token by default v1.24
What type of PR is it?
What is the Jira issue?
YUNIKORN-2903