Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[YUNIKORN-2960] Fix typos in Partition and Queue Configuration and App Placement Rules #500

Closed
wants to merge 6 commits into from
Closed

[YUNIKORN-2960] Fix typos in Partition and Queue Configuration and App Placement Rules #500

wants to merge 6 commits into from

Conversation

kousei47747
Copy link

What is this PR for?

Fix typos in Partition and Queue Configuration and App Placement Rules section.

Changes:

  1. defaultpartition.. =>default` partition.
  2. as a any other rule => as any other rule
  3. not the against the list of groups => not against the list of groups
  4. The behaviour of the this rule => The behaviour of this rule

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-2960

@kousei47747 kousei47747 changed the title Yunikorn 2960 [YUNIKORN-2960] Fix typos in Partition and Queue Configuration and App Placement Rules Nov 1, 2024
chenyulin0719
chenyulin0719 approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@chenyulin0719 chenyulin0719 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chenyulin0719
Copy link
Contributor

Thanks for creating this PR.
@kousei47747 . Just a reminder, please keep in mind to remove any unrelated commits in future PRs Thanks :)

github-actions bot pushed a commit that referenced this pull request Nov 5, 2024
@yunikorn-bot
Auto refresh: [YUNIKORN-2960] Fix typos in Partition and Queue Config…
a1ad180 
…uration and App Placement Rules (#500)
@kousei47747
Copy link
Author

@chenyulin0719 noted, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenyulin0719 chenyulin0719 chenyulin0719 approved these changes

Assignees

@kousei47747 kousei47747

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kousei47747 @chenyulin0719