[YUNIKORN-2081] Update karma in web UI test #151
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #151 +/- ##
=======================================
Coverage 66.66% 66.66%
=======================================
Files 1 1
Lines 30 30
=======================================
Hits 20 20
Misses 7 7
Partials 3 3 ☔ View full report in Codecov by Sentry. |
stu01509
approved these changes
Nov 27, 2023
brandboat
force-pushed
the
YUNIKORN-2081
branch
from
76a7961 to
a924836
Compare
brandboat
force-pushed
the
YUNIKORN-2081
branch
from
a924836 to
0a00bc8
Compare
wilfred-s
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Update karma-jasmine to version 5.1.0. Remove the dependency on ng-bullet since it is causing an error, as indicated in this link. Moreover, ng-bullet hasn't been updated for approximately 5 years. Some users have reported the issue, and there is a pull request attempting to address it, but it hasn't been merged into ng-bullet yet. The purpose of ng-bullet is to reduce the overall test execution time. However, after removing ng-bullet, I didn't observe a significant increase in test time (17.51s -> 18.44s).
What type of PR is it?
Todos
N/A
What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-2081
How should this be tested?
covered by unit tests
Screenshots (if appropriate)
N/A
Questions:
N/A