Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-2624] Implemented hotlinking to applications page using the query parameters #191

Closed
wants to merge 1 commit into from

Conversation

dcoric
Copy link
Contributor

@dcoric dcoric commented May 17, 2024

What is this PR for?

Application details can be hot-linked by passing query parameters of partition, queue, and applicationId. This will autoselect the application and display all of the details.

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-2624

How should this be tested?

With existing json-db.json these params can be used for testing: ?partition=cluster-2&queue=root.b&applicationId=application-sleep-0002

applicationId can be passed as a query parameter together with partition and queue. This will autoselect all of the options in the applications page.
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.77%. Comparing base (440f03b) to head (92b14fa).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #191   +/-   ##
=======================================
  Coverage   38.77%   38.77%           
=======================================
  Files           2        2           
  Lines          49       49           
=======================================
  Hits           19       19           
  Misses         27       27           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@wilfred-s wilfred-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, adding some further people to look at this

@brandboat brandboat changed the title [YUNIKORN-2491] Implemented hotlinking to applications page using the query parameters [YUNIKORN-2624] Implemented hotlinking to applications page using the query parameters May 31, 2024
Copy link
Member

@brandboat brandboat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I'm not familiar with Angular...

Tested this feature in my local env. Something like this http://localhost:9889/#/applications?partition=default&queue=root.default&applicationId=application-sleep-0001
image

works perfectly 😃

Copy link
Contributor

@chenyulin0719 chenyulin0719 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brandboat brandboat closed this in 58dab20 Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants