Skip to content

Commit

Permalink
libsparse: deal with build warning messages
Browse files Browse the repository at this point in the history
- mostly unused parameters, added defs.h to hold __unused macro
- read_all prototype not included, added output_file.h to acquire

Change-Id: Ib7ee00614acab53a6bd6a64f7e26a8c13dbe6297
  • Loading branch information
Mark Salyzyn committed Feb 28, 2014
1 parent b7a4868 commit 031a748
Show file tree
Hide file tree
Showing 4 changed files with 34 additions and 6 deletions.
23 changes: 23 additions & 0 deletions libsparse/defs.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
/*
* Copyright (C) 2014 The Android Open Source Project
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

#ifndef _LIBSPARSE_DEFS_H_

#ifndef __unused
#define __unused __attribute__((__unused__))
#endif

#endif /* _LIBSPARSE_DEFS_H_ */
9 changes: 5 additions & 4 deletions libsparse/output_file.c
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
#include <unistd.h>
#include <zlib.h>

#include "defs.h"
#include "output_file.h"
#include "sparse_format.h"
#include "sparse_crc32.h"
Expand Down Expand Up @@ -264,7 +265,7 @@ static struct output_file_ops gz_file_ops = {
.close = gz_file_close,
};

static int callback_file_open(struct output_file *out, int fd)
static int callback_file_open(struct output_file *out __unused, int fd __unused)
{
return 0;
}
Expand All @@ -287,7 +288,7 @@ static int callback_file_skip(struct output_file *out, int64_t off)
return 0;
}

static int callback_file_pad(struct output_file *out, int64_t len)
static int callback_file_pad(struct output_file *out __unused, int64_t len __unused)
{
return -1;
}
Expand Down Expand Up @@ -631,8 +632,8 @@ static struct output_file *output_file_new_normal(void)
}

struct output_file *output_file_open_callback(int (*write)(void *, const void *, int),
void *priv, unsigned int block_size, int64_t len, int gz, int sparse,
int chunks, int crc)
void *priv, unsigned int block_size, int64_t len,
int gz __unused, int sparse, int chunks, int crc)
{
int ret;
struct output_file_callback *outc;
Expand Down
3 changes: 2 additions & 1 deletion libsparse/sparse.c
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@

#include <sparse/sparse.h>

#include "defs.h"
#include "sparse_file.h"

#include "output_file.h"
Expand Down Expand Up @@ -189,7 +190,7 @@ int sparse_file_callback(struct sparse_file *s, bool sparse, bool crc,
return ret;
}

static int out_counter_write(void *priv, const void *data, int len)
static int out_counter_write(void *priv, const void *data __unused, int len)
{
int64_t *count = priv;
*count += len;
Expand Down
5 changes: 4 additions & 1 deletion libsparse/sparse_read.c
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@

#include <sparse/sparse.h>

#include "defs.h"
#include "output_file.h"
#include "sparse_crc32.h"
#include "sparse_file.h"
#include "sparse_format.h"
Expand Down Expand Up @@ -175,7 +177,8 @@ static int process_fill_chunk(struct sparse_file *s, unsigned int chunk_size,
}

static int process_skip_chunk(struct sparse_file *s, unsigned int chunk_size,
int fd, unsigned int blocks, unsigned int block, uint32_t *crc32)
int fd __unused, unsigned int blocks,
unsigned int block __unused, uint32_t *crc32)
{
int ret;
int chunk;
Expand Down

0 comments on commit 031a748

Please sign in to comment.