Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: delete deploy when upgrade #440

Merged
merged 4 commits into from
Sep 9, 2024
Merged

Conversation

ldming
Copy link
Collaborator

@ldming ldming commented Sep 9, 2024

@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines. label Sep 9, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 69.44444% with 11 lines in your changes missing coverage. Please review.

Project coverage is 43.38%. Comparing base (6ba8b9b) to head (f18da9c).

Files with missing lines Patch % Lines
pkg/cmd/kubeblocks/upgrade.go 67.74% 7 Missing and 3 partials ⚠️
pkg/cmd/report/zipwritter.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #440      +/-   ##
==========================================
+ Coverage   43.37%   43.38%   +0.01%     
==========================================
  Files         175      175              
  Lines       24626    24640      +14     
==========================================
+ Hits        10681    10690       +9     
- Misses      12697    12702       +5     
  Partials     1248     1248              
Flag Coverage Δ
unittests 43.38% <69.44%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ldming ldming merged commit fd7ac58 into main Sep 9, 2024
7 checks passed
@ldming ldming deleted the support/delete-deploy-when-upgrade branch September 9, 2024 04:09
@github-actions github-actions bot added this to the Release 0.9.1 milestone Sep 9, 2024
@ldming
Copy link
Collaborator Author

ldming commented Sep 9, 2024

/cherry-pick release-0.9

Copy link

github-actions bot commented Sep 9, 2024

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kbcli/actions/runs/10766373335

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants