Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: check helm release status before kubeblocks upgrade #447

Merged
merged 6 commits into from
Oct 10, 2024

Conversation

yipeng1030
Copy link
Contributor

@yipeng1030 yipeng1030 commented Sep 23, 2024

fix #398
Refer to helm upgrade
Check the release status of Kubeblocks before upgrade. Upgrade will run correctly only if the status is one of 'deployed', 'failed' and 'superseded' .

@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines. label Sep 23, 2024
@github-actions github-actions bot added size/L Denotes a PR that changes 100-499 lines. and removed size/M Denotes a PR that changes 30-99 lines. labels Sep 24, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 72.09302% with 12 lines in your changes missing coverage. Please review.

Project coverage is 43.45%. Comparing base (fd7ac58) to head (0ee0e29).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/util/helm/helm.go 72.72% 6 Missing and 3 partials ⚠️
pkg/cmd/kubeblocks/upgrade.go 70.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #447      +/-   ##
==========================================
+ Coverage   43.38%   43.45%   +0.06%     
==========================================
  Files         175      175              
  Lines       24640    24672      +32     
==========================================
+ Hits        10690    10721      +31     
+ Misses      12702    12700       -2     
- Partials     1248     1251       +3     
Flag Coverage Δ
unittests 43.45% <72.09%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yipeng1030 yipeng1030 marked this pull request as ready for review September 24, 2024 06:36
@yipeng1030 yipeng1030 merged commit cee94ef into main Oct 10, 2024
12 checks passed
@yipeng1030 yipeng1030 deleted the feature/check_helm_status_before_upgrade branch October 10, 2024 04:00
@github-actions github-actions bot added this to the Release 1.0 milestone Oct 10, 2024
@ldming
Copy link
Collaborator

ldming commented Oct 10, 2024

/cherry-pick release-0.9

Copy link

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kbcli/actions/runs/11274338706

github-actions bot pushed a commit that referenced this pull request Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] check the kubeblocks helm release status before upgrade
3 participants