Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix cluster chart version when auto register #462

Merged

Conversation

yipeng1030
Copy link
Contributor

@yipeng1030 yipeng1030 commented Oct 10, 2024

fix cluster chart version when auto register, use the version in Label.

@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines. label Oct 10, 2024
@yipeng1030 yipeng1030 marked this pull request as draft October 10, 2024 10:31
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 43.50%. Comparing base (e984a02) to head (fee9950).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
pkg/cmd/addon/addon.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #462   +/-   ##
=======================================
  Coverage   43.50%   43.50%           
=======================================
  Files         175      175           
  Lines       24885    24885           
=======================================
  Hits        10825    10825           
  Misses      12798    12798           
  Partials     1262     1262           
Flag Coverage Δ
unittests 43.50% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yipeng1030 yipeng1030 marked this pull request as ready for review October 10, 2024 10:38
@yipeng1030 yipeng1030 changed the title fix: fix cluster chart version when auto register chore: fix cluster chart version when auto register Oct 11, 2024
@yipeng1030 yipeng1030 merged commit 771cc8e into main Oct 11, 2024
20 of 23 checks passed
@yipeng1030 yipeng1030 deleted the bugfix/fix_missing_chart_version_when_auto_register branch October 11, 2024 09:02
@github-actions github-actions bot added this to the Release 1.0 milestone Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants