Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adapt update and dataprotection command #469

Merged
merged 6 commits into from
Oct 23, 2024

Conversation

wangyelei
Copy link
Contributor

No description provided.

@wangyelei wangyelei linked an issue Oct 18, 2024 that may be closed by this pull request
@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines. label Oct 18, 2024
@wangyelei wangyelei marked this pull request as draft October 18, 2024 06:05
@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 44.55338% with 509 lines in your changes missing coverage. Please review.

Project coverage is 42.23%. Comparing base (ae1093d) to head (b343ac5).

Files with missing lines Patch % Lines
pkg/cmd/dataprotection/backup.go 50.87% 113 Missing and 28 partials ⚠️
pkg/cmd/dataprotection/backuppolicy.go 39.28% 63 Missing and 5 partials ⚠️
pkg/action/list.go 4.41% 64 Missing and 1 partial ⚠️
pkg/cmd/dataprotection/restore.go 54.54% 47 Missing and 13 partials ⚠️
pkg/cmd/cluster/dataprotection.go 59.40% 37 Missing and 4 partials ⚠️
pkg/testing/fake.go 0.00% 32 Missing ⚠️
pkg/cmd/dataprotection/util.go 17.14% 25 Missing and 4 partials ⚠️
pkg/cluster/helper.go 0.00% 14 Missing ⚠️
pkg/cmd/cluster/update.go 59.37% 10 Missing and 3 partials ⚠️
pkg/cmd/backuprepo/storageprovider.go 47.82% 11 Missing and 1 partial ⚠️
... and 11 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #469      +/-   ##
==========================================
- Coverage   42.37%   42.23%   -0.14%     
==========================================
  Files         165      169       +4     
  Lines       22789    22815      +26     
==========================================
- Hits         9657     9637      -20     
- Misses      11991    12073      +82     
+ Partials     1141     1105      -36     
Flag Coverage Δ
unittests 42.23% <44.55%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added size/XXL Denotes a PR that changes 1000+ lines. and removed size/L Denotes a PR that changes 100-499 lines. labels Oct 18, 2024
@wangyelei wangyelei force-pushed the feature/adapt_cluster_update branch from 5b65dc7 to 5674803 Compare October 22, 2024 05:58
@wangyelei wangyelei force-pushed the feature/adapt_cluster_update branch from 3bd129b to 3c42554 Compare October 22, 2024 06:02
@wangyelei wangyelei marked this pull request as ready for review October 22, 2024 06:03
@wangyelei wangyelei changed the title chore: adapt update command chore: adapt update and dataprotection command Oct 22, 2024
@wangyelei wangyelei force-pushed the feature/adapt_cluster_update branch from b68322a to 023d9d4 Compare October 22, 2024 06:13
@wangyelei
Copy link
Contributor Author

/approved

@wangyelei wangyelei merged commit 1d61526 into main Oct 23, 2024
12 checks passed
@wangyelei wangyelei deleted the feature/adapt_cluster_update branch October 23, 2024 01:41
@github-actions github-actions bot added this to the Release 1.0 milestone Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Features] adapt cluster update command
4 participants