chore: tidy up promote and rebuild instance cmd with new api #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangyelei
requested review from
nayutah,
ldming,
heng4fun,
free6om,
leon-inf and
1aal
as code owners
wangyelei
changed the title
ldming
approved these changes
Jan 15, 2025
github-actions
bot
added
size/L
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #539 +/- ##
==========================================
- Coverage 41.20% 41.18% -0.02%
==========================================
Files 187 187
Lines 25264 25264
==========================================
- Hits 10409 10406 -3
- Misses 13681 13682 +1
- Partials 1174 1176 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
/approved |
apecloud-bot
approved these changes
Jan 15, 2025
|
/cherry-pick release-1.0 |
|
🤖 says: cherry pick action finished successfully 🎉! |
apecloud-bot
pushed a commit
that referenced
this pull request
Jan 15, 2025
Co-authored-by: wangyelei <[email protected]> (cherry picked from commit 00acda0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.