Skip to content

Commit

Permalink
chore: delete the secret-ref for the kafka account (#1447)
Browse files Browse the repository at this point in the history
  • Loading branch information
leon-inf authored Feb 6, 2025
1 parent 8b00fc3 commit 7022699
Show file tree
Hide file tree
Showing 6 changed files with 3 additions and 70 deletions.
14 changes: 0 additions & 14 deletions addons/kafka/templates/_helpers.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -197,17 +197,3 @@ Define kafka tools scripts tpl name
{{- define "kafka.toolsScriptsTplName" -}}
kafka-tools-scripts-tpl
{{- end -}}

{{/*
Define kafka default client system account secret name
*/}}
{{- define "kafka.defaultClientSystemAccountSecretName" -}}
kafka-client-secret
{{- end -}}

{{/*
Define kafka default superuser system account secret name
*/}}
{{- define "kafka.defaultSuperUserSystemAccountSecretName" -}}
kafka-superusers-secret
{{- end -}}
7 changes: 0 additions & 7 deletions addons/kafka/templates/account-client.yaml

This file was deleted.

7 changes: 0 additions & 7 deletions addons/kafka/templates/account-superusers.yaml

This file was deleted.

15 changes: 1 addition & 14 deletions addons/kafka/templates/cmpd-broker-27.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -39,11 +39,7 @@ spec:
clusterVarRef:
clusterUID: Required
- name: SUPER_USER
valueFrom:
credentialVarRef:
name: admin
username: Required
optional: false
value: admin
- name: POD_FQDN_LIST
valueFrom:
componentVarRef:
Expand Down Expand Up @@ -84,15 +80,6 @@ spec:
port:
name: broker
option: Optional
systemAccounts:
- name: client
secretRef:
name: {{ include "kafka.defaultClientSystemAccountSecretName" . }}
namespace: {{ .Release.Namespace }}
- name: admin
secretRef:
name: {{ include "kafka.defaultSuperUserSystemAccountSecretName" . }}
namespace: {{ .Release.Namespace }}
## serial is not used because rsm currently does not support kafka's role detection. The lack of role label during restart will affect the pod restart.
updateStrategy: BestEffortParallel
configs:
Expand Down
15 changes: 1 addition & 14 deletions addons/kafka/templates/cmpd-broker.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -33,11 +33,7 @@ spec:
clusterVarRef:
clusterUID: Required
- name: SUPER_USER
valueFrom:
credentialVarRef:
name: admin
username: Required
optional: false
value: admin
- name: POD_FQDN_LIST
valueFrom:
componentVarRef:
Expand Down Expand Up @@ -80,15 +76,6 @@ spec:
port:
name: broker
option: Optional
systemAccounts:
- name: client
secretRef:
name: {{ include "kafka.defaultClientSystemAccountSecretName" . }}
namespace: {{ .Release.Namespace }}
- name: admin
secretRef:
name: {{ include "kafka.defaultSuperUserSystemAccountSecretName" . }}
namespace: {{ .Release.Namespace }}
## serial is not used because rsm currently does not support kafka's role detection. The lack of role label during restart will affect the pod restart.
updateStrategy: BestEffortParallel
configs:
Expand Down
15 changes: 1 addition & 14 deletions addons/kafka/templates/cmpd-combine.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -36,11 +36,7 @@ spec:
clusterVarRef:
clusterUID: Required
- name: SUPER_USER
valueFrom:
credentialVarRef:
name: admin
username: Required
optional: false
value: admin
- name: POD_FQDN_LIST
valueFrom:
componentVarRef:
Expand Down Expand Up @@ -71,15 +67,6 @@ spec:
port:
name: broker
option: Optional
systemAccounts:
- name: client
secretRef:
name: {{ include "kafka.defaultClientSystemAccountSecretName" . }}
namespace: {{ .Release.Namespace }}
- name: admin
secretRef:
name: {{ include "kafka.defaultSuperUserSystemAccountSecretName" . }}
namespace: {{ .Release.Namespace }}
## serial is not used because rsm currently does not support kafka's role detection. The lack of role label during restart will affect the pod restart.
updateStrategy: BestEffortParallel
configs:
Expand Down

0 comments on commit 7022699

Please sign in to comment.