Skip to content

Commit

Permalink
chore: fix deploy/helm and addon_types format (#5804)
Browse files Browse the repository at this point in the history
  • Loading branch information
1aal authored Nov 9, 2023
1 parent 8691103 commit 1f0ecab
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 15 deletions.
2 changes: 1 addition & 1 deletion apis/extensions/v1alpha1/addon_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ type SelectorRequirement struct {
// The selector key. Valid values are KubeVersion, KubeGitVersion and KubeProvider.
// "KubeVersion" the semver expression of Kubernetes versions, i.e., v1.24.
// "KubeGitVersion" may contain distro. info., i.e., v1.24.4+eks.
// "KubeProvider" the Kubernetes provider, i.e., aws,gcp,azure,huaweiCloud,tencentCloud etc.
// "KubeProvider" the Kubernetes provider, i.e., aws, gcp, azure, huaweiCloud, tencentCloud etc.
// +kubebuilder:validation:Required
Key AddonSelectorKey `json:"key"`

Expand Down
8 changes: 4 additions & 4 deletions config/crd/bases/extensions.kubeblocks.io_addons.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -174,8 +174,8 @@ spec:
KubeGitVersion and KubeProvider. "KubeVersion" the semver
expression of Kubernetes versions, i.e., v1.24. "KubeGitVersion"
may contain distro. info., i.e., v1.24.4+eks. "KubeProvider"
the Kubernetes provider, i.e., aws,gcp,azure,huaweiCloud,tencentCloud
etc.
the Kubernetes provider, i.e., aws, gcp, azure, huaweiCloud,
tencentCloud etc.
enum:
- KubeGitVersion
- KubeVersion
Expand Down Expand Up @@ -567,8 +567,8 @@ spec:
KubeGitVersion and KubeProvider. "KubeVersion" the semver
expression of Kubernetes versions, i.e., v1.24. "KubeGitVersion"
may contain distro. info., i.e., v1.24.4+eks. "KubeProvider"
the Kubernetes provider, i.e., aws,gcp,azure,huaweiCloud,tencentCloud
etc.
the Kubernetes provider, i.e., aws, gcp, azure, huaweiCloud,
tencentCloud etc.
enum:
- KubeGitVersion
- KubeVersion
Expand Down
8 changes: 4 additions & 4 deletions deploy/helm/crds/extensions.kubeblocks.io_addons.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -174,8 +174,8 @@ spec:
KubeGitVersion and KubeProvider. "KubeVersion" the semver
expression of Kubernetes versions, i.e., v1.24. "KubeGitVersion"
may contain distro. info., i.e., v1.24.4+eks. "KubeProvider"
the Kubernetes provider, i.e., aws,gcp,azure,huaweiCloud,tencentCloud
etc.
the Kubernetes provider, i.e., aws, gcp, azure, huaweiCloud,
tencentCloud etc.
enum:
- KubeGitVersion
- KubeVersion
Expand Down Expand Up @@ -567,8 +567,8 @@ spec:
KubeGitVersion and KubeProvider. "KubeVersion" the semver
expression of Kubernetes versions, i.e., v1.24. "KubeGitVersion"
may contain distro. info., i.e., v1.24.4+eks. "KubeProvider"
the Kubernetes provider, i.e., aws,gcp,azure,huaweiCloud,tencentCloud
etc.
the Kubernetes provider, i.e., aws, gcp, azure, huaweiCloud,
tencentCloud etc.
enum:
- KubeGitVersion
- KubeVersion
Expand Down
6 changes: 0 additions & 6 deletions deploy/helm/templates/storageclass.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
{{- if and $scName .Values.storageClass.create }}
{{- $cloudProvider := (include "kubeblocks.cloudProvider" .) }}
{{- if eq $cloudProvider "aws" }}
---
apiVersion: storage.k8s.io/v1
kind: StorageClass
metadata:
Expand All @@ -19,7 +18,6 @@ reclaimPolicy: Delete
volumeBindingMode: WaitForFirstConsumer
---
{{- else if eq $cloudProvider "gcp" }}
---
apiVersion: storage.k8s.io/v1
kind: StorageClass
metadata:
Expand All @@ -36,7 +34,6 @@ reclaimPolicy: Delete
volumeBindingMode: WaitForFirstConsumer
---
{{- else if eq $cloudProvider "aliyun" }}
---
apiVersion: storage.k8s.io/v1
kind: StorageClass
metadata:
Expand All @@ -53,7 +50,6 @@ reclaimPolicy: Delete
volumeBindingMode: WaitForFirstConsumer
---
{{- else if eq $cloudProvider "tencentCloud" }}
---
apiVersion: storage.k8s.io/v1
kind: StorageClass
metadata:
Expand All @@ -68,7 +64,6 @@ provisioner: com.tencent.cloud.csi.cbs
volumeBindingMode: WaitForFirstConsumer
---
{{- else if eq $cloudProvider "azure" }}
---
## it doesn't work here because aks does not support .Capabilities.KubeVersion.GitVersion to judge the provider.
## refer: https://github.com/Azure/AKS/issues/3375
apiVersion: storage.k8s.io/v1
Expand All @@ -87,7 +82,6 @@ reclaimPolicy: Delete
volumeBindingMode: WaitForFirstConsumer
---
{{- else if eq $cloudProvider "huaweiCloud" }} # huawei cloud
---
apiVersion: storage.k8s.io/v1
kind: StorageClass
metadata:
Expand Down

0 comments on commit 1f0ecab

Please sign in to comment.