Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mongodb service role selector error #5860

Merged
merged 3 commits into from
Nov 16, 2023

Conversation

Y-Rookie
Copy link
Collaborator

No description provided.

@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines. label Nov 16, 2023
@Y-Rookie Y-Rookie changed the title fix: mongodb service role selector empty fix: mongodb service role selector error Nov 16, 2023
@github-actions github-actions bot added size/S Denotes a PR that changes 10-29 lines. and removed size/XS Denotes a PR that changes 0-9 lines. labels Nov 16, 2023
@Y-Rookie
Copy link
Collaborator Author

/approve

@apecloud-bot apecloud-bot added the approved PR Approved Test label Nov 16, 2023
@Y-Rookie
Copy link
Collaborator Author

/approve

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (d351da8) 68.39% compared to head (e993f7c) 68.24%.
Report is 3 commits behind head on main.

Files Patch % Lines
...roller/component/component_definition_convertor.go 25.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5860      +/-   ##
==========================================
- Coverage   68.39%   68.24%   -0.15%     
==========================================
  Files         287      287              
  Lines       32737    32740       +3     
==========================================
- Hits        22389    22345      -44     
- Misses       8504     8539      +35     
- Partials     1844     1856      +12     
Flag Coverage Δ
unittests 68.24% <40.00%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Y-Rookie Y-Rookie merged commit 8201d35 into main Nov 16, 2023
43 checks passed
@Y-Rookie Y-Rookie deleted the bugfix/mongodb-service-role-selector-empty branch November 16, 2023 13:03
@github-actions github-actions bot added this to the Release 0.8.0 milestone Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR Approved Test enhancement size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] mongodb creates failed, phase is always Abnormal, but no any workloads created
4 participants