Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pg cluster connect fail #5862

Merged
merged 3 commits into from
Nov 18, 2023
Merged

fix: pg cluster connect fail #5862

merged 3 commits into from
Nov 18, 2023

Conversation

1aal
Copy link
Contributor

@1aal 1aal commented Nov 17, 2023

e1a698e2-5613-49d9-a801-c671a6c0d758
d280865c-f5ef-4925-86b4-5a470fc55223
The password needs to be enclosed in quotation marks because it may contain special characters such as '&'.

Test:

@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines. label Nov 17, 2023
Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (d351da8) 68.39% compared to head (be7e8fa) 68.36%.
Report is 6 commits behind head on main.

Files Patch % Lines
...roller/component/component_definition_convertor.go 25.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5862      +/-   ##
==========================================
- Coverage   68.39%   68.36%   -0.03%     
==========================================
  Files         287      287              
  Lines       32737    32740       +3     
==========================================
- Hits        22389    22383       -6     
- Misses       8504     8509       +5     
- Partials     1844     1848       +4     
Flag Coverage Δ
unittests 68.36% <40.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Y-Rookie
Copy link
Collaborator

Other engines are similar, and may have the same problems

@github-actions github-actions bot added size/S Denotes a PR that changes 10-29 lines. and removed size/XS Denotes a PR that changes 0-9 lines. labels Nov 17, 2023
@1aal 1aal merged commit 2fff161 into main Nov 18, 2023
46 checks passed
@1aal 1aal deleted the bugfix/fix-pg-connect-failed branch November 18, 2023 07:47
@github-actions github-actions bot added this to the Release 0.8.0 milestone Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] kbcli connect cluster failed [BUG] kbcli connect pg cluster error:sh: 1: Syntax error: ")" unexpected
4 participants