Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support RollingUpdate #8577

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Conversation

free6om
Copy link
Contributor

@free6om free6om commented Dec 4, 2024

fixed #7913

Regarding instance updates, KubeBlocks has previously made several efforts, including role-based UpdateStrategy, PodUpdatePolicy, and automated RollingUpdate. However, it currently does not support fine-grained control over the RollingUpdate process. This proposal will provide control capabilities over both the number and speed of instance updates during the RollingUpdate process.

@free6om free6om added this to the Release 1.0.0 milestone Dec 4, 2024
@free6om free6om self-assigned this Dec 4, 2024
@free6om free6om requested review from leon-inf, Y-Rookie and a team as code owners December 4, 2024 08:15
@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines. label Dec 4, 2024
@free6om free6om changed the title feat: support InstanceUpdateStrategy feat: Support RollingUpdate Dec 4, 2024
apis/apps/v1/cluster_types.go Outdated Show resolved Hide resolved
@github-actions github-actions bot added size/L Denotes a PR that changes 100-499 lines. and removed size/M Denotes a PR that changes 30-99 lines. labels Dec 5, 2024
@wangyelei
Copy link
Contributor

only api for RollingUpdate and no implement for it?

@github-actions github-actions bot added size/XXL Denotes a PR that changes 1000+ lines. and removed size/L Denotes a PR that changes 100-499 lines. labels Dec 11, 2024
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 33.14286% with 117 lines in your changes missing coverage. Please review.

Project coverage is 60.28%. Comparing base (982672d) to head (72599d6).

Files with missing lines Patch % Lines
apis/apps/v1alpha1/cluster_conversion.go 0.00% 48 Missing ⚠️
apis/apps/v1alpha1/component_conversion.go 0.00% 20 Missing ⚠️
pkg/controller/component/its_convertor.go 0.00% 19 Missing ⚠️
pkg/controller/component/synthesize_component.go 55.55% 11 Missing and 1 partial ⚠️
...is/apps/v1alpha1/componentdefinition_conversion.go 0.00% 8 Missing ⚠️
pkg/controller/instanceset/reconciler_update.go 77.77% 4 Missing and 2 partials ⚠️
pkg/controller/builder/builder_component.go 0.00% 2 Missing ⚠️
...controller/builder/builder_component_definition.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8577      +/-   ##
==========================================
- Coverage   60.34%   60.28%   -0.07%     
==========================================
  Files         381      381              
  Lines       46215    46275      +60     
==========================================
+ Hits        27889    27897       +8     
- Misses      15654    15702      +48     
- Partials     2672     2676       +4     
Flag Coverage Δ
unittests 60.28% <33.14%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@starnop
Copy link
Contributor

starnop commented Jan 2, 2025

@free6om @weicao any update? 😄

@github-actions github-actions bot modified the milestones: Release 1.0.0, Release 0.9.3 Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Features] Supports upper-layer modification of the InstanceSet's UpdateStrategy
5 participants